Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api) : 토큰 응답시 쿠키 설정 (#96) #97

Merged
merged 2 commits into from
Jan 12, 2023
Merged

refactor(api) : 토큰 응답시 쿠키 설정 (#96) #97

merged 2 commits into from
Jan 12, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Jan 12, 2023

개요

작업사항

  • 프론트 next js 면...
  • 쿠키를 설정해야 리덕스같이 상태관리 init 할때 쿠키같이보내서 상태설정할수 있다고 합니다.
  • 원래 로컬스토릿지 이용했었는데 안된다구 하네요!

쿠기 두개 설정해놨습니다

변경로직

  • 내용을 적어주세요.

@ImNM ImNM added the Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 label Jan 12, 2023
@ImNM ImNM self-assigned this Jan 12, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 127 Code Smells

8.1% 8.1% Coverage
0.4% 0.4% Duplication

sanbonai06
sanbonai06 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@sanbonai06 sanbonai06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

9yujin
9yujin approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@9yujin 9yujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

천천히 작업해보게씀다

@ImNM ImNM merged commit 89ad30e into dev Jan 12, 2023
@ImNM ImNM deleted the refactor/96-jwt-cookie branch January 12, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbonai06 sanbonai06 sanbonai06 approved these changes

@9yujin 9yujin 9yujin approved these changes

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

@gengminy gengminy Awaiting requested review from gengminy gengminy is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@ImNM ImNM

Labels
Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔨[refactor] jwt 토큰 응답시 쿠키 설정
3 participants
@ImNM @9yujin @sanbonai06