feat : 결제 취소 관련 기능 개발 (#70) #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImNM
commented
Jan 11, 2023
Comment on lines
+21
to
+29
|
|
||
| @JsonCreator | ||
| static TossPaymentMethod findValue(String code) { | ||
| return Arrays.stream(TossPaymentMethod.values()) | ||
| .filter(PaymentMethod -> PaymentMethod.getKr().equals(code)) | ||
| .findFirst() | ||
| .orElseThrow(() -> PaymentsEnumNotMatchException.EXCEPTION); | ||
| } | ||
| } |
There was a problem hiding this comment.
이부분은 토스페이먼츠로 요청받아서 응답받는 리스폰트 디티오부분인데
jsonCreator 가 역직렬화 하는 어노테이션인데
토스에서 값을 "카드" 이런식으로줘서
위처럼 필터링 돌려서 역직렬화 하는 방식썻습니다!!
easyPay, card 코드도 마찬가지.
ImNM
commented
Jan 11, 2023
Comment on lines
-16
to
37
| private final Long amount; | ||
|
|
||
| @Schema(description = "결제금액") | ||
| private final Money amount; | ||
|
|
||
| public static CreateOrderResponse from(Order order, Profile profile) { | ||
| return CreateOrderResponse.builder() | ||
| .customerEmail(profile.getEmail()) | ||
| .customerName(profile.getName()) | ||
| .orderName(order.getOrderName()) | ||
| .orderId(order.getUuid()) | ||
| .amount(order.getTotalPaymentPrice().longValue()) | ||
| .amount(order.getTotalPaymentPrice()) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
이런식으로
응답에 Money 타입을 그대로 쓰세요!
sanbonai06
reviewed
Jan 12, 2023
| @@ -15,16 +16,19 @@ public class CreateCartResponse { | |||
| private final List<CartItemResponse> items; | |||
|
|
|||
| // 금액 | |||
| private final String totalPrice; | |||
| private final Money totalPrice; | |||
There was a problem hiding this comment.
금액 관련 정보들 Money로 매핑하겠습니다 좋네요
sanbonai06
reviewed
Jan 12, 2023
| import lombok.Builder; | ||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| @Builder | ||
| public class CreateOrderResponse { | ||
| @Schema(description = "UUId") |
sanbonai06
reviewed
Jan 12, 2023
Comment on lines
+16
to
+17
| public OrderResponse execute(String orderUuid) { | ||
| return orderMapper.toOrderResponse(orderUuid); |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
관리자 취소일경우 event_id 가 필요한데
민준이처럼
/api/v1/admin/events/{event_id}/order/{order_id}/cancel
뭐이렇게 url가져가고 useCase 만 저길로 옮기면되니깐!
괜찮을것같긴하네요
{ "success": true, "status": 200, "data": { "paymentInfo": { "paymentMethod": "간편 결제", "provider": "토스페이", "supplyAmount": "15000원", "discountAmount": "0원", "couponName": "사용하지 않음", "totalAmount": "15000원", "orderStatus": "환불 완료", "receiptUrl": "https://dashboard.tosspayments.com/sales-slip?transactionId=c12bjcpoyt6SKKAvoeLDysw5JVY9XTR3lpv7dANK2Z5%2B6qX3IdFZQ627sFhlQoUn&ref=PX" }, "tickets": [ { "ticketName": "계좌이체티켓", "orderNo": "R1000028-54", "ticketNos": "", "paymentAt": "2023-01-12T03:32:04", "userName": "이찬진", "orderLinePrice": "12000원", "purchaseQuantity": 3, "answers": [ { "optionGroupType": "Y/N", "questionName": "뒷풀이 참석 여부 조사", "questionDescription": "오케이포차 조사입니다.", "answer": "네", "additionalPrice": "1000원" }, { "optionGroupType": "Y/N", "questionName": "신한은행(110- )으로 3000원 입금 바랍니다.", "questionDescription": "계좌이체 확인후 티켓을 발급해드립니다 ( 승인 결제 )", "answer": "안갈꺼에요", "additionalPrice": "0원" } ] }, { "ticketName": "계좌이체티켓", "orderNo": "R1000028-55", "ticketNos": "", "paymentAt": "2023-01-12T03:32:04", "userName": "이찬진", "orderLinePrice": "3000원", "purchaseQuantity": 1, "answers": [ { "optionGroupType": "Y/N", "questionName": "뒷풀이 참석 여부 조사", "questionDescription": "오케이포차 조사입니다.", "answer": "아니오", "additionalPrice": "0원" }, { "optionGroupType": "Y/N", "questionName": "신한은행(110- )으로 3000원 입금 바랍니다.", "questionDescription": "계좌이체 확인후 티켓을 발급해드립니다 ( 승인 결제 )", "answer": "갈게요 ㅋㅋ", "additionalPrice": "0원" } ] } ], "refundInfo": { "endAt": "2023-01-12T18:10:51", "availAble": true }, "orderUuid": "e411b070-7e33-48b6-a3f7-d4fd4da9deb8", "orderId": 28 }, "timeStamp": "2023-01-12T03:34:30.60648" }변경로직