-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : [어드민] 발급 티켓 리스트 가져오기 API 개발 #94
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨어유!
이름이랑 전화번호 두개로 검색 가능 하면 될것 같습니다~!
DuDoong-Domain/src/main/java/band/gosrock/domain/common/vo/UserInfoVo.java
Show resolved
Hide resolved
DuDoong-Domain/src/main/java/band/gosrock/domain/domains/event/service/EventService.java
Show resolved
Hide resolved
DuDoong-Domain/src/main/java/band/gosrock/domain/domains/issuedTicket/domain/IssuedTicket.java
Show resolved
Hide resolved
...rc/main/java/band/gosrock/domain/domains/issuedTicket/service/IssuedTicketDomainService.java
Show resolved
Hide resolved
return new IssuedTicketDTO(issuedTicket); | ||
List<IssuedTicketOptionAnswer> issuedTicketOptionAnswers = | ||
createIssuedTicketRequest.getOptionAnswers().stream() | ||
.map( | ||
IssuedTicketOptionAnswer | ||
::orderOptionAnswerToIssuedTicketOptionAnswer) | ||
.toList(); | ||
/* | ||
티켓 옵션 답변 매핑 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
뭔가 orderOptionAnswer 가져가니깐
orderLine 도메인 객체로 티켓 생성하는것도 나쁘지않을것같아유
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
생각만하고 바꾸질 않았네요ㅠㅠ 수정하겠습니당
DuDoong-Common/src/main/java/band/gosrock/common/exception/ErrorCode.java
Show resolved
Hide resolved
public RetrieveIssuedTicketListResponse execute(Long page, Long eventId, String userName) { | ||
Long currentUserId = SecurityUtils.getCurrentUserId(); | ||
// 조회 유저 권한 인증 | ||
eventService.checkEventHost(currentUserId, eventId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
민준이 파트는 아니긴하지만
호스트 관리자 목록이있어서 그거까지 나중에 변경해야할듯하긴해용
이벤트가 어그리게이트가 된다면 ( 관리자 관리에 )
event.valid관리자()
뭐이런식으루!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠 일단 아직 이벤트 도메인에 관리자 목록 정보가 없어서 호스트로만 권한 검사하긴 했는데 관리자 목록 추가되면 수정하겠습니다.
...ng-Api/src/main/java/band/gosrock/api/issuedTicket/dto/response/RetrieveIssuedTicketDTO.java
Show resolved
Hide resolved
...ng-Api/src/main/java/band/gosrock/api/issuedTicket/dto/response/RetrieveIssuedTicketDTO.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
개요
작업사항
변경로직