Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿš€ :: Api-v0.0.2-2 #82

Merged
merged 1 commit into from
Jan 10, 2023
Merged

๐Ÿš€ :: Api-v0.0.2-2 #82

merged 1 commit into from
Jan 10, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Jan 10, 2023

๊ฐœ์š”

  • close #issueNumber

์ž‘์—…์‚ฌํ•ญ

  • ๋‚ด์šฉ์„ ์ ์–ด์ฃผ์„ธ์š”.

๋ณ€๊ฒฝ๋กœ์ง

  • ๋‚ด์šฉ์„ ์ ์–ด์ฃผ์„ธ์š”.

@ImNM ImNM merged commit 407ab85 into releases/Api Jan 10, 2023
@ImNM ImNM changed the title ๐Ÿš€ :: Api-v0.0.2-1 ๐Ÿš€ :: Api-v0.0.2-2 Jan 10, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.ย  ย  Quality Gate failed

Bug A 0 Bugs
Vulnerability E 2 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 118 Code Smells

9.8% 9.8% Coverage
0.0% 0.0% Duplication

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 10, 2023
View reviewed changes
DuDoong-Api/src/main/java/band/gosrock/api/auth/controller/AuthController.java
String queryString =
String.format(
"?idToken=%s&accessToken=%s&refreshToken=%s",
credentialFromKaKao.getIdToken(),
credentialFromKaKao.getAccessToken(),
credentialFromKaKao.getRefreshToken());
response.sendRedirect("http://" + host + "/kakao/callback" + queryString);
if (referer != null) {
response.sendRedirect(referer + "/kakao/callback" + queryString);

Check failure

Code scanning / SonarCloud

HTTP request redirections should not be open to forging attacks

<!--SONAR_ISSUE_KEY:AYWcY6-vRG-4eVcWa9Nk-->Change this code to not perform redirects based on user-controlled data. <p>See more on <a href="https://sonarcloud.io/project/issues?id=Gosrock_DuDoong-Backend&issues=AYWcY6-vRG-4eVcWa9Nk&open=AYWcY6-vRG-4eVcWa9Nk&pullRequest=82">SonarCloud</a></p>
DuDoong-Api/src/main/java/band/gosrock/api/auth/controller/AuthController.java
if (referer != null) {
response.sendRedirect(referer + "/kakao/callback" + queryString);
} else {
response.sendRedirect("https://" + host + "/kakao/callback" + queryString);

Check failure

Code scanning / SonarCloud

HTTP request redirections should not be open to forging attacks

<!--SONAR_ISSUE_KEY:AYWcY6-vRG-4eVcWa9Nj-->Change this code to not perform redirects based on user-controlled data. <p>See more on <a href="https://sonarcloud.io/project/issues?id=Gosrock_DuDoong-Backend&issues=AYWcY6-vRG-4eVcWa9Nj&open=AYWcY6-vRG-4eVcWa9Nj&pullRequest=82">SonarCloud</a></p>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbonai06 sanbonai06 Awaiting requested review from sanbonai06 sanbonai06 is a code owner

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

@gengminy gengminy Awaiting requested review from gengminy gengminy is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ImNM