Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api) : 카카오 oauth code 요청 성공후 클라이언트 리다이렉션 (#77) #78

Merged
merged 1 commit into from
Jan 10, 2023
Merged

refactor(api) : 카카오 oauth code 요청 성공후 클라이언트 리다이렉션 (#77) #78

merged 1 commit into from
Jan 10, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Jan 10, 2023

개요

작업사항

  • 규진이 요청에따라서 코드 응답후 호스트에따라 리다이렉션을 해줍니다.

변경로직

  • 내용을 적어주세요.

@ImNM ImNM added the Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 label Jan 10, 2023
@ImNM ImNM self-assigned this Jan 10, 2023
sanbonai06
sanbonai06 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@sanbonai06 sanbonai06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원하는게 많은 프론트 때문에 고생이 많으십니다 수고하셨습니다!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 10, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 120 Code Smells

9.8% 9.8% Coverage
0.0% 0.0% Duplication

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 10, 2023
View reviewed changes
DuDoong-Api/src/main/java/band/gosrock/api/auth/controller/AuthController.java
credentialFromKaKao.getIdToken(),
credentialFromKaKao.getAccessToken(),
credentialFromKaKao.getRefreshToken());
response.sendRedirect("http://" + host + "/kakao/callback" + queryString);

Check failure

Code scanning / SonarCloud

HTTP request redirections should not be open to forging attacks

<!--SONAR_ISSUE_KEY:AYWcM-unfWhBUqKqKjOe-->Change this code to not perform redirects based on user-controlled data. <p>See more on <a href="https://sonarcloud.io/project/issues?id=Gosrock_DuDoong-Backend&issues=AYWcM-unfWhBUqKqKjOe&open=AYWcM-unfWhBUqKqKjOe&pullRequest=78">SonarCloud</a></p>
@9yujin
Copy link
Member

9yujin commented Jan 10, 2023

원하는게 많은 프론트 때문에 고생이 많으십니다 수고하셨습니다!

예??

@ImNM ImNM merged commit e6b0f70 into dev Jan 10, 2023
@ImNM ImNM deleted the refactor/77-oauth-code-redirection branch January 10, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbonai06 sanbonai06 sanbonai06 approved these changes

@9yujin 9yujin 9yujin approved these changes

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

@gengminy gengminy Awaiting requested review from gengminy gengminy is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@ImNM ImNM

Labels
Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔨[refactor] oauth code 요청후 클라이언트 리다이렉션
3 participants
@ImNM @9yujin @sanbonai06