Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : 배치 이벤트 정산 프로세스 소스 정리 #554

Merged
merged 6 commits into from
Apr 2, 2023
Merged

refactor : 배치 이벤트 정산 프로세스 소스 정리 #554

merged 6 commits into from
Apr 2, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Mar 31, 2023

개요

작업사항

  • 소스를 좀 더 깔끔하게 해놨습니다.
  • 정산 금액 계산 관련 소스들은 EventSettlementDomainService 로 옮겼습니다.
  • 정산서pdf, 엑셀 이메일 호스트,관리자 발송시 중복되는 코드들은 SettlementEmailHelper 로 옮겼습니다.
  • 그외 큰 변화는 없슴다!

변경로직

  • 내용을 적어주세요.

@ImNM ImNM added the Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 label Mar 31, 2023
@ImNM ImNM self-assigned this Mar 31, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

0.0% 0.0% Coverage
0.4% 0.4% Duplication

gengminy
gengminy approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@gengminy gengminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cofls6581
cofls6581 approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@cofls6581 cofls6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ImNM ImNM merged commit edd4390 into dev Apr 2, 2023
@ImNM ImNM deleted the refactor/519-settlement-code-to-domain branch April 3, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengminy gengminy gengminy approved these changes

@cofls6581 cofls6581 cofls6581 approved these changes

@sanbonai06 sanbonai06 Awaiting requested review from sanbonai06 sanbonai06 is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@ImNM ImNM

Labels
Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔨[refactor] 정산 프로세스 코드 리팩토링
3 participants
@ImNM @cofls6581 @gengminy