Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : 준비중인 공연 자동 만료 해제 #536

Merged
merged 6 commits into from
Mar 8, 2023
Merged

Conversation

gengminy
Copy link
Member

@gengminy gengminy commented Mar 8, 2023

개요

작업사항

  • 오픈된 공연만 자동 만료 배치 작업에 포함되도록 수정
  • 오픈 안된 공연 검증 메소드명 수정
  • 이벤트 오픈 요청 시 시작 시간 검증 추가
  • 오픈 로직 변경에 따른 테스트 수정

변경로직

  • 위와 동일

@gengminy gengminy added For: API [이슈 대상] 외부 API Type: Errors/Bugs [이슈 목적] 버그, 애러 수정 Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 labels Mar 8, 2023
@gengminy gengminy self-assigned this Mar 8, 2023
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 47 to 50

public List<Event> queryEventsByEndAtBefore(LocalDateTime time) {
return eventRepository.queryEventsByEndAtBefore(time);
return eventRepository.queryEventsByEndAtBeforeAndStatusOpen(time);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

queryEventsByEndAtBefore 메소드 명도 수정되어야 될것같아요!

Copy link
Member

@kim-wonjin kim-wonjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버그수정 확인했슴당🐛

Copy link
Member

@cofls6581 cofls6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘쥐티엠

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@gengminy gengminy merged commit e123c74 into dev Mar 8, 2023
@gengminy gengminy deleted the fix/535-event-batch branch March 8, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For: API [이슈 대상] 외부 API Type: Errors/Bugs [이슈 목적] 버그, 애러 수정 Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛[BUG] 공연 종료 배치 준비중인 공연은 제외
4 participants