Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : 공연 조회 기획 변경 반영 #528

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix : 공연 조회 기획 변경 반영 #528

merged 1 commit into from
Mar 7, 2023

Conversation

gengminy
Copy link
Member

@gengminy gengminy commented Mar 6, 2023

개요

작업사항

  • 공연 검색 시 닫힌 공연도 나오도록 기획 변경분 반영
  • 공연 생성시간 -> 시작 시간으로 정렬 순서 변경

변경로직

  • 내용을 적어주세요.

@gengminy gengminy added For: API [이슈 대상] 외부 API Type: Errors/Bugs [이슈 목적] 버그, 애러 수정 Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 labels Mar 6, 2023
@gengminy gengminy self-assigned this Mar 6, 2023
ImNM
ImNM approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구웃~

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

cofls6581
cofls6581 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@cofls6581 cofls6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ImNM ImNM merged commit bd6a2dd into dev Mar 7, 2023
@ImNM ImNM deleted the fix/527-closed-event branch March 8, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofls6581 cofls6581 cofls6581 approved these changes

@ImNM ImNM ImNM approved these changes

@sanbonai06 sanbonai06 Awaiting requested review from sanbonai06 sanbonai06 is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@gengminy gengminy

Labels
For: API [이슈 대상] 외부 API Type: Errors/Bugs [이슈 목적] 버그, 애러 수정 Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
두둥
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛[BUG] 닫힌 공연 응답 오류
3 participants
@gengminy @ImNM @cofls6581