Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test : 발급 티켓 관련 vo들 테스트 코드 추가 및 발급티켓 응답값에 티켓 payType 추가 #487

Merged
merged 2 commits into from
Feb 27, 2023
Merged

test : 발급 티켓 관련 vo들 테스트 코드 추가 및 발급티켓 응답값에 티켓 payType 추가 #487

merged 2 commits into from
Feb 27, 2023

Conversation

sanbonai06
Copy link
Member

@sanbonai06 sanbonai06 commented Feb 27, 2023 •
edited
Loading

개요

작업사항

  • 발급 티켓 관련 vo들 테스트 코드를 간단하게 추가 해 보았습니다.
  • 또, 발급 티켓 응답값에 티켓 payType을 추가했습니다.

테스트 커버리지 1% 상승

변경로직

  • 내용을 적어주세요.

@sanbonai06 sanbonai06 added For: API [이슈 대상] 외부 API Type: Test Type: Test [이슈 목적] 테스트 코드 추가, 수정 labels Feb 27, 2023
@sanbonai06 sanbonai06 self-assigned this Feb 27, 2023
ImNM
ImNM approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 459 Code Smells

22.5% 22.5% Coverage
0.7% 0.7% Duplication

gengminy
gengminy approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@gengminy gengminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vo 변경 확인입니다

@sanbonai06 sanbonai06 merged commit a16903d into dev Feb 27, 2023
@sanbonai06 sanbonai06 deleted the feat/360-issuedTicket-test-coverage branch February 27, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengminy gengminy gengminy approved these changes

@ImNM ImNM ImNM approved these changes

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@sanbonai06 sanbonai06

Labels
For: API [이슈 대상] 외부 API Type: Test Type: Test [이슈 목적] 테스트 코드 추가, 수정
Projects
두둥
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [feature] issuedTicket 테스트 커버리지 올리기
3 participants
@sanbonai06 @ImNM @gengminy