Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : order approve not delete user #477

Merged
merged 4 commits into from
Feb 27, 2023
Merged

fix : order approve not delete user #477

merged 4 commits into from
Feb 27, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Feb 27, 2023

개요

작업사항

  • 어드민 주문 승인 테이블에서는 탈퇴한 유저가 조회안되게,
  • 주문 승인시 ( 누가 강제로 api 호출할경우 ) 탈퇴한 유저면 주문 취소되게

변경로직

  • 내용을 적어주세요.

@ImNM ImNM added For: API [이슈 대상] 외부 API For: Utils [이슈 대상] API, 모델, 뷰를 제외한 백엔드 로직 Type: Errors/Bugs [이슈 목적] 버그, 애러 수정 labels Feb 27, 2023
@ImNM ImNM self-assigned this Feb 27, 2023
sanbonai06
sanbonai06 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@sanbonai06 sanbonai06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

탈퇴 유저 제거 좋아요 LGTM

kim-wonjin
kim-wonjin approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@kim-wonjin kim-wonjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

탈퇴유저 처리 확인 LGTM

@ImNM ImNM merged commit c804fdc into dev Feb 27, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 453 Code Smells

21.4% 21.4% Coverage
0.7% 0.7% Duplication

@ImNM ImNM deleted the fix/470-order-approve-not-delete-user branch February 27, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-wonjin kim-wonjin kim-wonjin approved these changes

@sanbonai06 sanbonai06 sanbonai06 approved these changes

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

@gengminy gengminy Awaiting requested review from gengminy gengminy is a code owner

Assignees

@ImNM ImNM

Labels
For: API [이슈 대상] 외부 API For: Utils [이슈 대상] API, 모델, 뷰를 제외한 백엔드 로직 Type: Errors/Bugs [이슈 목적] 버그, 애러 수정
Projects
None yet
Milestone
No milestone
3 participants
@ImNM @sanbonai06 @kim-wonjin