Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : 공연 삭제 기능 추가 #382

Merged
merged 2 commits into from
Feb 20, 2023
Merged

feat : 공연 삭제 기능 추가 #382

merged 2 commits into from
Feb 20, 2023

Conversation

gengminy
Copy link
Member

개요

작업사항

  • 공연 삭제 기능을 soft delete 로 구현하였습니다
    1. 발급된 티켓이 있음, 2. 발급된 티켓이 없어서 OPEN 상태임
  • 위에 해당하면 삭제 불가입니다
  • EventStatus 에 Deleted 추가해서 이걸로 검사합니다
  • Event 삭제 슬랙 알림 설정

변경로직

  • Event 엔티티에 @Where 추가하여 이벤트 관련 쿼리마다 자동 검사
  • EventService 에서 IssuedTicketAdeptor 호출하여 검사
  • EventStatusDeleted 값 추가
  • Soft Delete 이기 때문에 삭제는 PATCH 메서드로 호출합니다

@gengminy gengminy added the For: API [이슈 대상] 외부 API label Feb 20, 2023
@gengminy gengminy added this to the 두둥 스프린트 2차 milestone Feb 20, 2023
@gengminy gengminy self-assigned this Feb 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 373 Code Smells

21.1% 21.1% Coverage
0.0% 0.0% Duplication

@gengminy gengminy added the Type: Feature [이슈 목적] 새로운 기능 추가 label Feb 20, 2023
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +169 to +172
// 오픈된 이벤트는 삭제 불가
if (this.status == OPEN) throw CannotDeleteByOpenEventException.EXCEPTION;
if (this.status == DELETED) throw AlreadyDeletedStatusException.EXCEPTION;
this.status = DELETED;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조건확인입니둥

Copy link
Member

@cofls6581 cofls6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘쥐티엠~~

@gengminy gengminy merged commit d2c26fe into dev Feb 20, 2023
@gengminy gengminy deleted the feature/380-delete-event branch February 20, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🚀 [feature] 공연 삭제 기능
3 participants