refactor : 두둥티켓 계좌정보 분리 #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImNM
approved these changes
Feb 19, 2023
Comment on lines
57
to
65
| // 은행명 | ||
| private String bankName; | ||
|
|
||
| // 계좌번호 | ||
| private String accountNumber; | ||
|
|
||
| // 예금주 | ||
| private String accountHolder; | ||
|
|
There was a problem hiding this comment.
accountInfoVo를 TicketItem 내부에
embedded 시키는게 어떨까유?
gengminy
approved these changes
Feb 19, 2023
Comment on lines
42
to
44
| @NotNull | ||
| @Schema(defaultValue = "0", nullable = false, example = "4000") | ||
| private Long price; |
There was a problem hiding this comment.
@NotNull 말고 @Positive 아니면 @Min 을 이용해서 음수 처리도 해주면 좋을 거 같아요
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
-계좌정보 vo로 분리
변경로직