Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : 두둥 티켓 적용 #361

Merged
merged 2 commits into from
Feb 15, 2023
Merged

feat : 두둥 티켓 적용 #361

merged 2 commits into from
Feb 15, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Feb 15, 2023

개요

작업사항

  • 주문쪽은 뭐 크게 변한거없이 적용했습니다.
  • 승인/선착순 두개 타입으로 그대로 적용했으며
  • 아이템의 타입에 따라서 승인 주문을 생성할지 , 선착순을 생성할지 시도했습니다.

변경로직

  • HostRollAllowed 어노테이션에 트랜잭션 끌지 켤지 옵션넣어줬습니다 @kim-wonjin
  • 디폴트는 true이므로 기존껀 건드실 필요없지만
  • 트랜잭션을 분리해야할 경우 적용하시길 바랍니다. ( 락을 잡고 새로운 트랜잭션에서 수행할경우 )

@ImNM ImNM added For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가 labels Feb 15, 2023
@ImNM ImNM self-assigned this Feb 15, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 359 Code Smells

20.8% 20.8% Coverage
0.0% 0.0% Duplication

gengminy
gengminy approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@gengminy gengminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

트랜잭션 옵션 확인했습니다 👍

cofls6581
cofls6581 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@cofls6581 cofls6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고하셨음둥

@ImNM ImNM merged commit 10ca04c into dev Feb 15, 2023
@ImNM ImNM deleted the feature/340-dudoong-tickets branch February 15, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengminy gengminy gengminy approved these changes

@cofls6581 cofls6581 cofls6581 approved these changes

@sanbonai06 sanbonai06 Awaiting requested review from sanbonai06 sanbonai06 is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@ImNM ImNM

Labels
For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [feature] 두둥 티켓 주문 적용
3 participants
@ImNM @cofls6581 @gengminy