Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug : 티켓 옵션 리스트 순서 고정 #351

Merged
merged 1 commit into from
Feb 12, 2023
Merged

bug : 티켓 옵션 리스트 순서 고정 #351

merged 1 commit into from
Feb 12, 2023

Conversation

kim-wonjin
Copy link
Member

개요

작업사항

  • 옵션 리스트 조회 시 마다 순서가 바뀌는 문제 해결

변경로직

  • hasheset -> list 로 변경

@kim-wonjin kim-wonjin added For: API [이슈 대상] 외부 API Type: Errors/Bugs [이슈 목적] 버그, 애러 수정 labels Feb 12, 2023
@kim-wonjin kim-wonjin self-assigned this Feb 12, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 320 Code Smells

16.3% 16.3% Coverage
0.0% 0.0% Duplication

ImNM
ImNM approved these changes Feb 12, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set 자료구조 쓰고
불러올때 소팅 주는 어노테이션 있어요
워딩이 생각안나서 한번 검색 부탁...!

sanbonai06
sanbonai06 approved these changes Feb 12, 2023
View reviewed changes
Copy link
Member

@sanbonai06 sanbonai06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cofls6581
cofls6581 approved these changes Feb 12, 2023
View reviewed changes
Copy link
Member

@cofls6581 cofls6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kim-wonjin
Copy link
Member Author

생각해보니 굳이 set을 쓰지 않아도 될것 같아서 list로 변경했슴당!

@kim-wonjin kim-wonjin merged commit 325f996 into dev Feb 12, 2023
@kim-wonjin kim-wonjin deleted the refactor/312-get-ticket-options branch February 12, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofls6581 cofls6581 cofls6581 approved these changes

@sanbonai06 sanbonai06 sanbonai06 approved these changes

@ImNM ImNM ImNM approved these changes

@gengminy gengminy Awaiting requested review from gengminy gengminy is a code owner

Assignees

@kim-wonjin kim-wonjin

Labels
For: API [이슈 대상] 외부 API Type: Errors/Bugs [이슈 목적] 버그, 애러 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔨[refactor] 티켓 옵션 리스트 순서 고정하기
4 participants
@kim-wonjin @ImNM @sanbonai06 @cofls6581