feat : 밸리데이션 정리 및 밸리데이션 테스트 코드 작성 #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImNM
approved these changes
Feb 11, 2023
Comment on lines
+33
to
37
|
|
||
| public Boolean is(IssuedTicket issuedTicket) { | ||
| return issuedTicket.getIssuedTicketStatus() == IssuedTicketStatus.ENTRANCE_INCOMPLETE; | ||
| } | ||
| } |
|
Kudos, SonarCloud Quality Gate passed!
|
gengminy
approved these changes
Feb 11, 2023
| @@ -190,7 +190,7 @@ public void entrance() { | |||
| 티켓이 입장 완료 상태가 아니면 입장 취소 할 수 없음 | |||
| */ | |||
| public void entranceCancel() { | |||
| if (this.issuedTicketStatus != IssuedTicketStatus.ENTRANCE_COMPLETED) { | |||
| if (!this.issuedTicketStatus.isAfterEntrance()) { | |||
| throw CanNotCancelEntranceException.EXCEPTION; | |||
| } | |||
| this.issuedTicketStatus = IssuedTicketStatus.ENTRANCE_INCOMPLETE; | |||
There was a problem hiding this comment.
Event 엔티티의 setStatus() 참고하면 중복된 코드 구조 줄일 수 있을 거 같아욤
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
변경로직