Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : security open regex #344

Merged
merged 1 commit into from
Feb 11, 2023
Merged

fix : security open regex #344

merged 1 commit into from
Feb 11, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Feb 11, 2023

개요

작업사항

  • 보니깐 d+ 로하면 한글자밖에 지원을 안하더라고요..?

  • 스택오버플로우보고했는데 나쁜넘들.

  • 그래서 숫자만 가능하게 regex로 넣었슴다

변경로직

  • 내용을 적어주세요.

@ImNM ImNM added Status: URGENT [이슈 상태] 긴급 해결 요망 Type: Errors/Bugs [이슈 목적] 버그, 애러 수정 labels Feb 11, 2023
@ImNM ImNM self-assigned this Feb 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 314 Code Smells

16.0% 16.0% Coverage
0.0% 0.0% Duplication

sanbonai06
sanbonai06 approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@sanbonai06 sanbonai06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gengminy
gengminy approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@gengminy gengminy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정규식 확인입니다 근데 [0-9]+ 해야 1글자 이상으로 인식되지 않나요? *은 0글자 이상일텐데유

@ImNM
Copy link
Member Author

ImNM commented Feb 11, 2023

정규식 확인입니다 근데 [0-9]+ 해야 1글자 이상으로 인식되지 않나요? *은 0글자 이상일텐데유

+$ 하년 14 1400 등 다 대응가능합니더

@ImNM ImNM merged commit 800c076 into dev Feb 11, 2023
@gengminy
Copy link
Member

$ 붙이면 잘 되는군요 굿입니다

@ImNM ImNM deleted the fix/343-security-open-regex branch February 15, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengminy gengminy gengminy approved these changes

@sanbonai06 sanbonai06 sanbonai06 approved these changes

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@ImNM ImNM

Labels
Status: URGENT [이슈 상태] 긴급 해결 요망 Type: Errors/Bugs [이슈 목적] 버그, 애러 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛[BUG] 시큐리티 open regex 수정
3 participants
@ImNM @gengminy @sanbonai06