Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : 발급 티켓 입장 처리 시 이메일 전송 로직 추가 #341

Merged
merged 2 commits into from
Feb 11, 2023
Merged

feat : 발급 티켓 입장 처리 시 이메일 전송 로직 추가 #341

merged 2 commits into from
Feb 11, 2023

Conversation

sanbonai06
Copy link
Member

개요

작업사항

  • 발급 티켓 입장 시 EntranceIssuedTicketEvent 이벤트 발행
  • 해당 이벤트 핸들러를 통해 커밋이 일어난 후 이메일 전송 로직 추가
  • 이메일 템플릿 추가
    스크린샷 2023-02-11 오전 1 24 47
  • 이메일 문구 피드백 받습니다

변경로직

  • 내용을 적어주세요.

@sanbonai06 sanbonai06 added For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가 labels Feb 10, 2023
@sanbonai06 sanbonai06 requested a review from ImNM as a code owner February 10, 2023 16:25
@sanbonai06 sanbonai06 self-assigned this Feb 10, 2023
ImNM
ImNM approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

베리굿~
즐감 멘트 좋네요~

.../src/main/java/band/gosrock/domain/common/events/issuedTicket/EntranceIssuedTicketEvent.java Show resolved Hide resolved
DuDoong-Domain/src/main/java/band/gosrock/domain/domains/issuedTicket/domain/IssuedTicket.java Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 314 Code Smells

16.0% 16.0% Coverage
0.0% 0.0% Duplication

cofls6581
cofls6581 approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@cofls6581 cofls6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘에이쥐티엠~

@sanbonai06 sanbonai06 merged commit cafc2ec into dev Feb 11, 2023
@sanbonai06 sanbonai06 deleted the feat/317-entrance-email branch February 11, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofls6581 cofls6581 cofls6581 approved these changes

@ImNM ImNM ImNM approved these changes

@gengminy gengminy Awaiting requested review from gengminy gengminy is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@sanbonai06 sanbonai06

Labels
For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가
Projects
두둥
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [feature] 발급 티켓 입장 처리 도메인 이벤트 추가
3 participants
@sanbonai06 @ImNM @cofls6581