Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : 이미지 키 값으로만 받도록 변경 #335

Merged
merged 2 commits into from
Feb 10, 2023
Merged

refactor : 이미지 키 값으로만 받도록 변경 #335

merged 2 commits into from
Feb 10, 2023

Conversation

gengminy
Copy link
Member

개요

작업사항

  • 정책 변경으로 이벤트 DetailImages 필드 제거
  • 관련 이미지 vo 필드명 전부 ImageKey 가 아닌 Image 로 통일
  • request dto 에서만 ImageKey 라고 명칭 통일

변경로직

  • 위와 같음

@gengminy gengminy added For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 labels Feb 10, 2023
@gengminy gengminy added this to the 두둥 스프린트 2차 milestone Feb 10, 2023
@gengminy gengminy self-assigned this Feb 10, 2023
ImNM
ImNM approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘쥐티엠!!!“

kim-wonjin
kim-wonjin approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@kim-wonjin kim-wonjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gengminy gengminy merged commit 9b1b629 into dev Feb 10, 2023
@gengminy gengminy deleted the feature/333-image-key branch February 10, 2023 07:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 313 Code Smells

16.2% 16.2% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-wonjin kim-wonjin kim-wonjin approved these changes

@ImNM ImNM ImNM approved these changes

@sanbonai06 sanbonai06 Awaiting requested review from sanbonai06 sanbonai06 is a code owner

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

Assignees

@gengminy gengminy

Labels
For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
두둥
Status: Done
Milestone
두둥 스프린트 2차
Development

Successfully merging this pull request may close these issues.

🚀 [feature] 이벤트 이미지 키값으로 받기
3 participants
@gengminy @ImNM @kim-wonjin