Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : 승인 대기중인 주문시 티켓 미발급으로 인한 널접근 오류 #334

Merged
merged 5 commits into from
Feb 10, 2023
Merged

fix : 승인 대기중인 주문시 티켓 미발급으로 인한 널접근 오류 #334

merged 5 commits into from
Feb 10, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Feb 10, 2023 •
edited
Loading

개요

작업사항

  • 제목과 같습니당
  • 좀 더 안전하게 정보를 불러와서 500오류를 없앴습니당.
  • 이벤트 관리페이지에서 주문정보 상세조회api를 새로 만들었습니당
  • 클라이언트가 보기 편하도록 스웨거 문서 정렬좀 했습니다.
    무제

변경로직

  • 내용을 적어주세요.

@ImNM ImNM added For: API [이슈 대상] 외부 API Type: Errors/Bugs [이슈 목적] 버그, 애러 수정 Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 labels Feb 10, 2023
@ImNM ImNM self-assigned this Feb 10, 2023
gengminy
gengminy approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@gengminy gengminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정렬 굿입니다 👍

kim-wonjin
kim-wonjin approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@kim-wonjin kim-wonjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문서정렬 짱!!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 315 Code Smells

16.1% 16.1% Coverage
0.0% 0.0% Duplication

@ImNM ImNM merged commit 7c25e73 into dev Feb 10, 2023
@ImNM ImNM deleted the fix/296-not-showing-pending-order branch February 10, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-wonjin kim-wonjin kim-wonjin approved these changes

@gengminy gengminy gengminy approved these changes

@sanbonai06 sanbonai06 Awaiting requested review from sanbonai06 sanbonai06 is a code owner

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

Assignees

@ImNM ImNM

Labels
For: API [이슈 대상] 외부 API Type: Errors/Bugs [이슈 목적] 버그, 애러 수정 Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛[BUG] 주문 조회시 진행중 상태일경우 제외
3 participants
@ImNM @gengminy @kim-wonjin