refactor : 전화번호 libphonenumber 적용 #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImNM
commented
Feb 8, 2023
Comment on lines
+54
to
+59
|
|
||
| /** 01000000000 format */ | ||
| public String getNaverSmsToNumber() throws NumberParseException { | ||
| String nationalFormat = this.getNationalFormat(); | ||
| return nationalFormat.replaceAll("-", ""); | ||
| } |
There was a problem hiding this comment.
@cofls6581 채린이는 vo 받아서 이걸로 얻어오면 될듯
user.getProfile().getPhoneNumberVo(). getNaverSmsToNumber();
같이 뎁스 너무 길어지면
user 엔티티에
user.getNaverSmsToNumber() 메소드 만드세용
이렇게 뎁스 쭐이는거 용어가있는데 까먹었넴
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
카카오톡에서 넘겨주는 전화번호 형식은 libphonenumber 패키지를 사용한 형식입니다
국제전화번호횽식
공식 문서에도 위 모듈 참고하라고 적혀있더라고요
https://github.com/google/libphonenumber
PhoneNumberVo 만들었고
해당 vo로 리턴하면 JsonValue로 010-xxxx-xxxx 형식으로 내려줍니다.
{ "success": true, "status": 200, "data": { "userId": 24, "userName": "ddd", "email": "asdfasdf@naver.com", "phoneNumber": "010-xxxx-xxxx", "profileImage": "http://k.kakaocdn.net/dn/QPtC7/btqX09yP4mb/asdfasdf/img_640x640.jpg", "createdAt": "2023-02-09T02:42:19" }, "timeStamp": "2023-02-09T02:42:37.442277" }변경로직