Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : 카카오 회원가입시 실제 이름 우선 후 없으면 프로필 이름 불러오기 #323

Merged
merged 1 commit into from
Feb 8, 2023
Merged

refactor : 카카오 회원가입시 실제 이름 우선 후 없으면 프로필 이름 불러오기 #323

merged 1 commit into from
Feb 8, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Feb 7, 2023 •
edited
Loading

개요

작업사항

  • 제목과 같습니다.
  • 동의 항목에 프로필은 고정인데
  • 이름을 추가 요청 받습니다.
  • 해당 부분 이름 우선시 이후 프로필 이름 우선시로 처리했습니다

변경로직

  • 내용을 적어주세요.

@ImNM ImNM added the Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 label Feb 7, 2023
@ImNM ImNM self-assigned this Feb 7, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 305 Code Smells

16.5% 16.5% Coverage
0.0% 0.0% Duplication

cofls6581
cofls6581 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@cofls6581 cofls6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘쥐티엠!

gengminy
gengminy approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@gengminy gengminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ImNM ImNM merged commit a57f3d8 into dev Feb 8, 2023
@ImNM ImNM deleted the refactor/314-kakao-profile-name branch February 8, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengminy gengminy gengminy approved these changes

@cofls6581 cofls6581 cofls6581 approved these changes

@sanbonai06 sanbonai06 Awaiting requested review from sanbonai06 sanbonai06 is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@ImNM ImNM

Labels
Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔨[refactor] 카카오 회원가입시 이름을 프로필 닉네임으로 설정
3 participants
@ImNM @cofls6581 @gengminy