Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 응원톡 랜덤 조회 쿼리 파라미터 추가 및 랜덤 쿼리 위해 nativeQuery로 리팩토링 #315

Merged
merged 4 commits into from
Feb 8, 2023
Merged

refactor: 응원톡 랜덤 조회 쿼리 파라미터 추가 및 랜덤 쿼리 위해 nativeQuery로 리팩토링 #315

merged 4 commits into from
Feb 8, 2023

Conversation

sanbonai06
Copy link
Member

개요

작업사항

  • 기존 로직에서는 응원톡 랜덤 조회 시 쿼리파라미터를 받지 않고 1개로 고정이었으나 쿼리파라미터를 통해 원하는 갯수 만큼 랜덤으로 가져오도록 리팩토링 했습니다.
  • 여러 개의 레코드를 랜덤으로 가져오는 로직을 짜기 위해선 기존의 QueryDsl 로직으로는 불가능하여 native query를 이용하였습니다.

변경로직

  • 내용을 적어주세요.

@sanbonai06 sanbonai06 added For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 labels Feb 6, 2023
@sanbonai06 sanbonai06 self-assigned this Feb 6, 2023
ImNM
ImNM approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DuDoong-Api/src/main/java/band/gosrock/api/comment/controller/CommentController.java Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 308 Code Smells

16.6% 16.6% Coverage
0.0% 0.0% Duplication

cofls6581
cofls6581 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@cofls6581 cofls6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! offset 파라미터 추가 구욷

@sanbonai06 sanbonai06 merged commit 6bbf63c into dev Feb 8, 2023
@sanbonai06 sanbonai06 deleted the refactor/311-get-comment-queryParam branch February 8, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofls6581 cofls6581 cofls6581 approved these changes

@ImNM ImNM ImNM approved these changes

@gengminy gengminy Awaiting requested review from gengminy gengminy is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@sanbonai06 sanbonai06

Labels
For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
두둥
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔨[refactor] 응원글 랜덤 조회 쿼리 파라미터에 따른 갯수 기능으로 리팩토링
3 participants
@sanbonai06 @ImNM @cofls6581