Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 응원글 조회 API 인증 과정 삭제 #310

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

sanbonai06
Copy link
Member

개요

작업사항

  • 기존에 걸려있던 응원톡 조회 API의 인증을 삭제했습니다.
  • securityConfig에 url패턴 추가 및 SecurityRequirement 어노테이션 분리

변경로직

  • 내용을 적어주세요.

@sanbonai06 sanbonai06 added the For: API [이슈 대상] 외부 API label Feb 5, 2023
@sanbonai06 sanbonai06 self-assigned this Feb 5, 2023
@@ -28,7 +28,6 @@
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RestController;

@SecurityRequirement(name = "access-token")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

민준님 스웨거에서 자물쇠 편하게 없애라고
@DisableSwaggerSecurity
어노테이션 만들어놨어요...
SecurityRequirement 그대로 두시고

api 메소드에 붙이시면 자물쇠 빠집니다..
https://github.com/Gosrock/DuDoong-Backend/pull/287/files#diff-9eff638abce5e4df3afe461cfc0a6e6b1323587396314c8299308fbdc56459e0R51-R57

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 303 Code Smells

16.9% 16.9% Coverage
0.0% 0.0% Duplication

Copy link
Member

@cofls6581 cofls6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구욷 고생하셨습니다!

@sanbonai06 sanbonai06 merged commit 36f83fc into dev Feb 6, 2023
@sanbonai06 sanbonai06 deleted the fix/300-delete-comment-auth branch February 6, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For: API [이슈 대상] 외부 API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🔨[refactor] 응원톡 조회 인증 제거
3 participants