Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 응원톡 무한 스크롤 방식 리팩토링 및 호스트 검증 AOP로 변경 #290

Merged
merged 2 commits into from
Feb 3, 2023
Merged

refactor: 응원톡 무한 스크롤 방식 리팩토링 및 호스트 검증 AOP로 변경 #290

merged 2 commits into from
Feb 3, 2023

Conversation

sanbonai06
Copy link
Member

개요

작업사항

  • 찬진님과 경민님의 변경사항에 맞춰 무한 스크롤 방식을 리팩토링 했습니다.
  • 또, 호스트 검증 로직들을 만들어주신 AOP를 이용하도록 변경했습니다.

변경로직

  • 내용을 적어주세요.

@sanbonai06 sanbonai06 added For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 labels Feb 3, 2023
@sanbonai06 sanbonai06 self-assigned this Feb 3, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 304 Code Smells

17.0% 17.0% Coverage
0.0% 0.0% Duplication

ImNM
ImNM approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘쥐티엠

gengminy
gengminy approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@gengminy gengminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리팩토링 확인입니다 👍

@sanbonai06 sanbonai06 merged commit cf44a0c into dev Feb 3, 2023
@sanbonai06 sanbonai06 deleted the refactor/289-slice-refactoring branch February 3, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengminy gengminy gengminy approved these changes

@ImNM ImNM ImNM approved these changes

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@sanbonai06 sanbonai06

Labels
For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
22th-gosrock
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔨[refactor] 응원톡 무한 스크롤 방식 리팩토링 및 호스트 검증 AOP 적용
3 participants
@sanbonai06 @ImNM @gengminy