Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor : 이벤트 , 아이템 조회 공개 api #287

Merged
merged 4 commits into from
Feb 3, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Feb 3, 2023

개요

작업사항

  • 이벤트 디테일조회
  • 이벤트에 관련한 상품조회 공개.

변경로직

@ImNM ImNM self-assigned this Feb 3, 2023
Copy link
Member

@gengminy gengminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공개 API 확인입니다 LGTM 👍

Comment on lines 36 to 39
.mvcMatchers(HttpMethod.GET, "/v1/events/*")
.permitAll()
.mvcMatchers(HttpMethod.GET, "/v1/events/*/ticketItems")
.permitAll()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와일드 카드로 해두면 나중에 GET /events/뭐시기 같은거 추가하면 문제가 안 생기려나요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

숫자받는걸로 수정해둘게융!

Copy link
Member

@sanbonai06 sanbonai06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 303 Code Smells

16.9% 16.9% Coverage
0.0% 0.0% Duplication

@ImNM ImNM merged commit 2f02495 into dev Feb 3, 2023
@ImNM ImNM deleted the refactor/286-event-item-api-public branch February 3, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔨[refactor] 이벤트,상품관련 조회 공개 처리
3 participants