Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: issuedTicket 도메인 테스트 추가 및 리팩토링 #285

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

sanbonai06
Copy link
Member

개요

작업사항

  • 발급 티켓 도메인 내부 메서드 테스트 로직 작성했습니다.
  • 추가로 테스트 로직 작성 중 리팩사항이 조금 보여서 수정한 부분들이 있습니다.
  • 아직 도메인 서비스 테스트 로직 작성이 완료되지 않았지만 작업사항이 생긴 관계로 작업 후 이슈 파서 새로 작업하겠습니다.

변경로직

  • issuedTicketOptionAnswer과 option분리 (option => optionId)
  • issuedTicket의 userInfoVo와 itemInfoVo 생성 변경

@sanbonai06 sanbonai06 added Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 Type: Test Type: Test [이슈 목적] 테스트 코드 추가, 수정 labels Feb 3, 2023
@sanbonai06 sanbonai06 self-assigned this Feb 3, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 307 Code Smells

16.8% 16.8% Coverage
0.0% 0.0% Duplication

Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿!

.map(
issuedTicketOptionAnswer ->
issuedTicketOptionAnswer.getOption().getAdditionalPrice())
.map(IssuedTicketOptionAnswer::getAdditionalPrice)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿~

Copy link
Member

@gengminy gengminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment on lines -34 to +32
@ManyToOne(fetch = FetchType.LAZY)
@JoinColumn(name = "option_id")
private Option option;
private Long optionId;

private Money additionalPrice = Money.ZERO;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

@sanbonai06 sanbonai06 merged commit 42415f6 into dev Feb 3, 2023
@sanbonai06 sanbonai06 deleted the feat/227-issued-ticket-test branch February 3, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 Type: Test Type: Test [이슈 목적] 테스트 코드 추가, 수정
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🚀 [feature] 티켓 발급 관련 테스트 코드 추가 및 전체적인 테스트 진행
3 participants