Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : DateFormat 형식 변경 #284

Merged
merged 3 commits into from
Feb 3, 2023
Merged

refactor : DateFormat 형식 변경 #284

merged 3 commits into from
Feb 3, 2023

Conversation

gengminy
Copy link
Member

@gengminy gengminy commented Feb 2, 2023

개요

작업사항

  • yyyy-mm-dd 에서 yyyy.mm.dd 로 컨벤션이 변경되었습니다
  • @DateFormat 과 @Schema 에서 포맷을 모두 변경했습니다
  • 관련 오류로 @DateFormat 적용 안될 수 있으니 Approve 이후 DB 엎어주세요

변경로직

  • 내용을 적어주세요.

@gengminy gengminy added For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 labels Feb 2, 2023
@gengminy gengminy self-assigned this Feb 2, 2023
@gengminy gengminy changed the title refactor : dateformat 형식 변경 refactor : DateFormat 형식 변경 Feb 2, 2023
ImNM
ImNM approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디비랑 관련된 vo 에도
데이트 포맷 적어주면
디비에 다르게 값이 들어가나요?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 288 Code Smells

15.5% 15.5% Coverage
0.0% 0.0% Duplication

@gengminy
Copy link
Member Author

gengminy commented Feb 3, 2023

디비랑 관련된 vo 에도

데이트 포맷 적어주면

디비에 다르게 값이 들어가나요?

넹 형식대로 들어가요

@ImNM
Copy link
Member

ImNM commented Feb 3, 2023

디비랑 관련된 vo 에도
데이트 포맷 적어주면
디비에 다르게 값이 들어가나요?

넹 형식대로 들어가요

음... 괜찮겠죠...?
내 주문내역 불러오기 에
Mysql 함수로 시간 더하는거있는데
좀... 괜찮을려나? 우려되긴하네요

@gengminy
Copy link
Member Author

gengminy commented Feb 3, 2023

디비랑 관련된 vo 에도
데이트 포맷 적어주면
디비에 다르게 값이 들어가나요?

넹 형식대로 들어가요

음... 괜찮겠죠...? 내 주문내역 불러오기 에 Mysql 함수로 시간 더하는거있는데 좀... 괜찮을려나? 우려되긴하네요

image

저장은 그대로고 표시만 바뀌네요!

sanbonai06
sanbonai06 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@sanbonai06 sanbonai06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿! 👍

@gengminy gengminy merged commit 0450bb1 into dev Feb 3, 2023
@gengminy gengminy deleted the refactor/283-dateforamt branch February 3, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbonai06 sanbonai06 sanbonai06 approved these changes

@ImNM ImNM ImNM approved these changes

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@gengminy gengminy

Labels
For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔨[refactor] DateFormat 형식 변경
3 participants
@gengminy @ImNM @sanbonai06