refactor : 마이페이지 내 예매목록조회 슬라이스 적용 #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengminy
approved these changes
Feb 3, 2023
Comment on lines
117
to
123
| @Operation(summary = "마이페이지 내 예매목록 조회") | ||
| @GetMapping | ||
| public PageResponse<OrderBriefElement> getMyOrders( | ||
| public SliceResponse<OrderBriefElement> getMyOrders( | ||
| @ParameterObject @RequestParam Boolean showing, | ||
| @ParameterObject @PageableDefault(size = 10) Pageable pageable) { | ||
| @ParameterObject @PageableDefault Pageable pageable) { | ||
| return readOrderUseCase.getMyOrders(showing, pageable); | ||
| } |
There was a problem hiding this comment.
@PageableDefault 사이즈 지정 안하면 20인가로 되던데 괜찮나유
There was a problem hiding this comment.
@PageableDefault사이즈 지정 안하면 20인가로 되던데 괜찮나유
디폴트가 10 이라고 회색글자 적히더라구요
Comment on lines
31
to
32
| // OrderSpecifier[] orderBy = QueryDslUtil.getOrderSpecifiers(Order.class, pageable); | ||
| // 오류남 |
There was a problem hiding this comment.
요거 나중에 더 개선해볼게요 일단 정렬조건 id.desc() 로 다 고정합시다
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
변경로직