Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : image url 발급 api 추가 #262

Merged
merged 5 commits into from
Feb 1, 2023
Merged

feat : image url 발급 api 추가 #262

merged 5 commits into from
Feb 1, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Feb 1, 2023

개요

작업사항

  • s3 프레사인 url 발급 api
  • cloudFront 적용 ( https://asset.dudoong.com )
  • 클라이언트들한텐 이미지 키값만 받아오면됩니다. 앞에 도메인 은 동적으로 붙여서 내려줍니다.
  • 키 생성방식
  • {환경 : prod,staging,test} /{종류 : user , host ,event}/ {해당아이디 }/{uuid}.{확장자 : jpeg , png}

변경로직

  • image Vo 를 만들었습니당.
  • 이벤트의 3장 디테일 이미지는 빠질것같아서 안건들였슴니다
  • 뭔가 안돌아간다..하면 그냥 디비 밀어주세요..

@ImNM ImNM added For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가 labels Feb 1, 2023
@ImNM ImNM self-assigned this Feb 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 276 Code Smells

16.1% 16.1% Coverage
0.0% 0.0% Duplication

gengminy
gengminy approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@gengminy gengminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지 적용 확인입니다 👍

kim-wonjin
kim-wonjin approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@kim-wonjin kim-wonjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프리사인드 Url 발급 확인이용!🌱

@ImNM ImNM merged commit 7a78038 into dev Feb 1, 2023
@ImNM ImNM deleted the feature/131-image-api branch February 1, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-wonjin kim-wonjin kim-wonjin approved these changes

@gengminy gengminy gengminy approved these changes

@sanbonai06 sanbonai06 Awaiting requested review from sanbonai06 sanbonai06 is a code owner

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

Assignees

@ImNM ImNM

Labels
For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [feature] 이미지 api 추가
3 participants
@ImNM @gengminy @kim-wonjin