Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : HostRole 명칭 수정 #257

Merged
merged 6 commits into from
Feb 1, 2023
Merged

refactor : HostRole 명칭 수정 #257

merged 6 commits into from
Feb 1, 2023

Conversation

gengminy
Copy link
Member

@gengminy gengminy commented Feb 1, 2023 •
edited
Loading

개요

작업사항

  • HostRole 명칭 변경 (HOST -> GUEST / SUPER_HOST -> MANAGER, MASTER)
  • 커스텀 AOP 사용 편의성 및 직관성 향상을 위해 바꾸게 되었습니다
  • 마스터도 SUPER_HOST -> MASTER 로 역할을 부여했습니다
  • 기존 검증 로직에서 마스터도 슈퍼호스트 권한을 주도록 하여서 금방 처리했습니다
  • PR Approve 이후 롤 이름 충돌이 나서 기존 DB 한번 밀어야합니다

변경로직

  • 위와 같음.

@gengminy gengminy added For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 labels Feb 1, 2023
@gengminy gengminy self-assigned this Feb 1, 2023
ImNM
ImNM approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘쥐티엠

sanbonai06
sanbonai06 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@sanbonai06 sanbonai06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB 밀어야하는거 확인입니다. 수고하셨어요 LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 275 Code Smells

16.2% 16.2% Coverage
0.0% 0.0% Duplication

@gengminy gengminy merged commit 36f0178 into dev Feb 1, 2023
@gengminy gengminy deleted the refactor/255-hostrole branch February 1, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbonai06 sanbonai06 sanbonai06 approved these changes

@ImNM ImNM ImNM approved these changes

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@gengminy gengminy

Labels
For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔨[refactor] HostRole 수정
3 participants
@gengminy @ImNM @sanbonai06