New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : host role Host 용 생성, 어노테이션 필드 리팩토링 #256

Merged

ImNM merged 2 commits into dev from refactor/254-host-role-aop

Feb 1, 2023

Member

ImNM commented Feb 1, 2023 •

edited

Loading

개요

이전 작업사항

작업사항

hostId 로도 찾아올수 있게끔 만들었습니다.
캐시가 되니깐 밑에서 뭐 호스트랑 이벤트 불러와도 디비 안거칩니다!

변경로직

사용 방법이 좀 변했습니다
보니깐 이넘값도 어노테이션으로 넘겨줄수 있더라고요
그래서 스트링에서 받던걸 이넘으로 넘겼습니다.

HostQualification 이랑 FindHostFrom 입니당

// 이벤트 용
 @HostRolesAllowed(role = MANAGER, findHostFrom = EVENT_ID)
    public EventResponse execute(Long eventId, UpdateEventDetailRequest updateEventDetailRequest) {
// 호스트 용
  @HostRolesAllowed(role = MANAGER, findHostFrom = HOST_ID)
    public HostDetailResponse execute(Long hostId, UpdateHostSlackRequest updateHostSlackRequest)


          refactor : host role Host 용 생성

e04f1c2

ImNM self-assigned this

ImNM requested review from sanbonai06, cofls6581, gengminy and kim-wonjin as code owners

February 1, 2023 05:37

ImNM added For: API Type: Refactor labels


          style : findhostFrom 카멜적용

66de8d9

Member Author

ImNM commented Feb 1, 2023

계층 적용은 아무리 생각해봐도
지금 현구조로 되면 되는것 같더라고요?

그래서 그냥 냅뒀습니다!
한번 씩 생각해봐주세요

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
277 Code Smells

16.2% Coverage
0.0% Duplication

gengminy approved these changes

View reviewed changes

Member

gengminy left a comment

드디어 HOST 에도 적용되는군요 LGTM👍

sanbonai06 approved these changes

View reviewed changes

Member

sanbonai06 left a comment

아주 좋네요 멋있습니당 👍

ImNM merged commit 4340168 into dev

ImNM deleted the refactor/254-host-role-aop branch

February 1, 2023 06:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gengminy gengminy approved these changes

sanbonai06 sanbonai06 approved these changes

cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Labels

For: API Type: Refactor