-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature : 이벤트에 속한 옵션그룹 조회 (어드민용) #252
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!고생하셨습니다
@@ -20,6 +21,11 @@ public OptionGroup queryOptionGroup(Long optionGroupId) { | |||
.orElseThrow(() -> OptionGroupNotFoundException.EXCEPTION); | |||
} | |||
|
|||
public List<OptionGroup> findAllByEventId(Long eventId) { | |||
return optionGroupRepository.findAllByEvent_IdAndOptionGroupStatus( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 언더바 빼면 좋을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ticketItemRepository에 노경민씨가 만들어놓은거 보구 맞춘건데 같이뺄까여? @gengminy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
매핑된 여러 Entity들을 통해서 조회하는 쿼리같은 경우 QueryDsl 써서 해결하는게 더 직관적이고 좋을 것 같다는 생각이 듭니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⭐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
그 상품에 관련한 옵션 조회는 이미 나온건감?
넹! |
개요
작업사항
변경로직