feat : 공연 상세 및 체크리스트 조회 구현 #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImNM
approved these changes
Jan 31, 2023
Comment on lines
104
to
107
| public void setStatus(EventStatus status) { | ||
| this.status = status; | ||
| } | ||
|
|
There was a problem hiding this comment.
Open , Close 등으로 메서드명 나누고
검증로직 들어가야 할 것 같습니다!
DuDoong-Domain/src/main/java/band/gosrock/domain/domains/event/domain/EventDetail.java
Outdated
Show resolved
Hide resolved
Comment on lines
65
to
76
| public Boolean hasEventBasic() { | ||
| return this.eventBasic != null && this.eventBasic.isValid(); | ||
| } | ||
|
|
||
| public Boolean hasEventPlace() { | ||
| return this.eventPlace != null && this.eventPlace.isValid(); | ||
| } | ||
|
|
||
| public Boolean hasEventDetail() { | ||
| return this.eventDetail != null && this.eventDetail.isValid(); | ||
| } | ||
|
|
There was a problem hiding this comment.
isValid 보단 isUpdated? 등 다른메소드 이름이 더 명확한것같은데
어떻게 생각하시나유
There was a problem hiding this comment.
isValid 보단 isUpdated? 등 다른메소드 이름이 더 명확한것같은데 어떻게 생각하시나유
일단 바꿔볼게요
DuDoong-Api/src/main/java/band/gosrock/api/event/service/ReadEventChecklistUseCase.java
Outdated
Show resolved
Hide resolved
DuDoong-Api/src/main/java/band/gosrock/api/event/service/ReadEventDetailUseCase.java
Outdated
Show resolved
Hide resolved
DuDoong-Api/src/main/java/band/gosrock/api/event/service/ReadEventDetailUseCase.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
PREPARING상태일 경우엔 호스트 유저만 조회하게 했음변경로직