Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : 이벤트 조회 분리 #240

Merged
merged 4 commits into from
Jan 31, 2023
Merged

feat : 이벤트 조회 분리 #240

merged 4 commits into from
Jan 31, 2023

Conversation

gengminy
Copy link
Member

@gengminy gengminy commented Jan 31, 2023 •
edited
Loading

개요

작업사항

  • 호스트 별 이벤트 조회와 개인 별 이벤트 조회 분리
  • 불필요한 파일 및 로직 제거
  • 리스트 관련 파일명 EventList -> Events 등 복수형으로 변경
{
        "hostId": 11,
        "hostName": "고스락",
        "eventId": 1,
        "posterImage": "https://s3.dudoong.com/image",
        "name": "고스락 제 22회 정기공연",
        "startAt": "2023-03-20T12:00:00",
        "placeName": "롤링홀",
        "status": "PREPARING"
}
  • 이벤트 관련 리턴값에 호스트 아이디 + 호스트 명 추가
  • 아직 이벤트 디테일이 정확하게 나온 것 같지 않아 일단 작업 종료

변경로직

  • 위와 같음

@gengminy gengminy added For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가 labels Jan 31, 2023
@gengminy gengminy requested a review from ImNM as a code owner January 31, 2023 02:49
@gengminy gengminy self-assigned this Jan 31, 2023
ImNM
ImNM approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘쥐티엠

kim-wonjin
kim-wonjin approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@kim-wonjin kim-wonjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개인별 이벤트 조회로 분리한 거 확인하였습니당 LGTM🌱

@gengminy gengminy merged commit 74f5309 into dev Jan 31, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 264 Code Smells

17.1% 17.1% Coverage
0.0% 0.0% Duplication

@ImNM ImNM deleted the feature/220-event-detail branch January 31, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-wonjin kim-wonjin kim-wonjin approved these changes

@ImNM ImNM ImNM approved these changes

@sanbonai06 sanbonai06 Awaiting requested review from sanbonai06 sanbonai06 is a code owner

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

Assignees

@gengminy gengminy

Labels
For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [feature] 이벤트 조회 분리
3 participants
@gengminy @ImNM @kim-wonjin