feat : 이벤트 티켓상품 조회 #238
Merged
feat : 이벤트 티켓상품 조회 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImNM
approved these changes
Jan 30, 2023
Comment on lines
17
to
21
| public OptionGroup queryOptionGroup(Long optionGroupId) { | ||
| return optionGroupRepository | ||
| .findById(optionGroupId) | ||
| .findByIdAndOptionGroupStatus(optionGroupId, OptionGroupStatus.VALID) | ||
| .orElseThrow(() -> OptionGroupNotFoundException.EXCEPTION); | ||
| } |
Comment on lines
18
to
22
| public TicketItem queryTicketItem(Long ticketItemId) { | ||
| return ticketItemRepository | ||
| .findById(ticketItemId) | ||
| .findByIdAndTicketItemStatus(ticketItemId, TicketItemStatus.VALID) | ||
| .orElseThrow(() -> TicketItemNotFoundException.EXCEPTION); | ||
| } |
|
근데 스쿼시머지할 때 이름좀 바꿔주세요 컨벤션 맞춰서 ㅎㅎ |
|
Kudos, SonarCloud Quality Gate passed!
|
gengminy
approved these changes
Jan 31, 2023
Comment on lines
+48
to
+50
| @Enumerated(EnumType.STRING) | ||
| @ColumnDefault(value = "'VALID'") | ||
| private OptionGroupStatus optionGroupStatus = OptionGroupStatus.VALID; |
There was a problem hiding this comment.
요 부분 @ColumnDefault 굳이 안적어줘도 대입 연산하면 기본값 들어가지 않나요?
There was a problem hiding this comment.
작업사항에 적어놨습니다만 ㅎㅎ!!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
@ColumnDefault는 이미 쌓인 로컬 데이터들 초기화 땜시 잠시 넣었음
변경로직