Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : 서버에러 슬랙 알림 추가 #235

Merged
merged 3 commits into from
Jan 31, 2023
Merged

feat : 서버에러 슬랙 알림 추가 #235

merged 3 commits into from
Jan 31, 2023

Conversation

gengminy
Copy link
Member

개요

작업사항

  • 500 번대 내부 서버 에러 슬랙 알림 추가했습니다

image

  • 알람 형식은 이렇게 나옵니다
  • spring profile 이 staging, prod 로 정확할 때만 알림이 표시되게 했습니다

image

  • 모킹 하는 방법이 없어서 일단 프로파일을 직접 꺼내서 일치할때만 호출시켰습니다
  • 더 좋은 방법이 있다면 알려주세요

변경로직

  • 위와 같음

@gengminy gengminy added For: Utils [이슈 대상] API, 모델, 뷰를 제외한 백엔드 로직 Type: Feature [이슈 목적] 새로운 기능 추가 labels Jan 30, 2023
@gengminy gengminy requested a review from ImNM as a code owner January 30, 2023 07:07
@gengminy gengminy self-assigned this Jan 30, 2023
ImNM
ImNM approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goodgood

kim-wonjin
kim-wonjin approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@kim-wonjin kim-wonjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 마크다운으로 적용할수 있구나 신기방기

DuDoong-Infrastructure/src/main/resources/application-infrastructure.yml
Comment on lines +15 to +17
slack:
webhook:
token: ${SLACK_WEBHOOK_TOKEN}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

환경변수 없데이트 카톡으로 확인했슴둥

@gengminy gengminy merged commit 87d83d1 into dev Jan 31, 2023
@gengminy gengminy deleted the feature/221-slack branch January 31, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-wonjin kim-wonjin kim-wonjin approved these changes

@ImNM ImNM ImNM approved these changes

@sanbonai06 sanbonai06 Awaiting requested review from sanbonai06 sanbonai06 is a code owner

@cofls6581 cofls6581 Awaiting requested review from cofls6581 cofls6581 is a code owner

Assignees

@gengminy gengminy

Labels
For: Utils [이슈 대상] API, 모델, 뷰를 제외한 백엔드 로직 Type: Feature [이슈 목적] 새로운 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [feature] 500번대 에러 슬랙 알림
3 participants
@gengminy @ImNM @kim-wonjin