feat : 티켓상품 옵션 조회 #234
Merged
feat : 티켓상품 옵션 조회 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImNM
approved these changes
Jan 30, 2023
Comment on lines
16
to
17
| @RedissonLock(LockName = "티켓상품", identifier = "ticketItemId") | ||
| public GetTicketItemOptionResponse execute(Long eventId, Long ticketItemId) { |
There was a problem hiding this comment.
조회 용은 락 걸 필요 없을것 같아요
어차피 프론트 넘어가서 새로고침 안하면 똑같으니깐?
Comment on lines
41
to
44
| TicketItem ticketItem = ticketItemAdaptor.queryTicketItem(ticketItemId); | ||
| ticketItem.checkEventId(eventId); | ||
| List<Long> optionGroupIds = ticketItem.getOptionGroupIds(); | ||
| List<OptionGroup> optionGroups = optionGroupAdaptor.findAllByIds(optionGroupIds); |
"optionGroups": [
{
"optionGroupId": 1,
"type": "Y/N",
"name": "뒷풀이 참여 여부",
"description": "공연이 끝난 후 오케이포차에서 진행하는 뒷풀이에 참여할 것인가요?",
"options": [
{
"optionId": 1,
"answer": "YES", ///. <--- 예 아니요 로 응답해줘야되지않나 싶음...!
"additionalPrice": "10000원"
},
{
"optionId": 2,
"answer": "NO",
"additionalPrice": "0원"
}
]
},
|
gengminy
approved these changes
Jan 30, 2023
Comment on lines
-28
to
29
| public static CreateTicketOptionResponse from(OptionGroup optionGroup) { | ||
| public static TicketOptionResponse from(OptionGroup optionGroup) { | ||
|
|
There was a problem hiding this comment.
response dto의 static 메소드 명은 of 로 통일하는게 어떨까요?
dto -> of / vo -> from 으로 다들 쓰고 있는 거 같아요
There was a problem hiding this comment.
from 매개변수 하나있을땨
of 여러개있을때
이렇게 쓰고있어요 전!
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
{ "success": true, "status": 200, "data": { "optionGroups": [ { "optionGroupId": 1, "type": "Y/N", "name": "뒷풀이 참여 여부", "description": "공연이 끝난 후 오케이포차에서 진행하는 뒷풀이에 참여할 것인가요?", "options": [ { "optionId": 1, "answer": "예", "additionalPrice": "10000원" }, { "optionId": 2, "answer": "아니요", "additionalPrice": "0원" } ] }, { "optionGroupId": 3, "type": "주관식", "name": "추천인이 누구인가요?", "description": "추천인 이름을 한명만 적어주세요", "options": [ { "optionId": 5, "answer": "", "additionalPrice": "0원" } ] } ] }, "timeStamp": "2023-01-30T04:02:59.221643" }변경로직