refactor : order,cart 에러 문서화, 세세한 검증 추가 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImNM
commented
Jan 29, 2023
Comment on lines
+165
to
+170
| public void validPurchaseLimit(Long quantity) { | ||
| if (this.purchaseLimit < quantity) { | ||
| throw TicketPurchaseLimitException.EXCEPTION; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
@sanbonai06 민준아 근데 아이템 구매 갯수 제한 이것도 검증 되었남?
내쪽에서도 하긴하는데 너쪽에서도 추가검증 해도좋을듯
cofls6581
reviewed
Jan 29, 2023
| import band.gosrock.domain.domains.event.exception.EventIsNotOpenStatusException; | ||
| import band.gosrock.domain.domains.event.exception.EventTicketingTimeIsPassedException; | ||
| import band.gosrock.domain.domains.ticket_item.exception.TicketItemQuantityLackException; | ||
| import band.gosrock.domain.domains.ticket_item.exception.TicketPurchaseLimitException; | ||
|
|
||
| @ExceptionDoc | ||
| public class CreateCartExceptionDocs implements SwaggerExampleExceptions { |
ImNM
commented
Jan 29, 2023
Comment on lines
+61
to
+72
| /** 모든 질문지 ( 옵션그룹 )에 응답했는지 검증합니다. ( 변화 했는지 검증 ) */ | ||
| public void validOptionNotChange(Order order, TicketItem item) { | ||
| List<OrderLineItem> orderLineItems = order.getOrderLineItems(); | ||
| List<Long> itemsOptionGroupIds = item.getOptionGroupIds(); | ||
| orderLineItems.forEach( | ||
| orderLineItem -> { | ||
| if (!Objects.equals( | ||
| getAnswerOptionGroupIds(orderLineItem), itemsOptionGroupIds)) { | ||
| throw OrderItemOptionChangedException.EXCEPTION; | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
옵션이 변화했는지 검증로직은 일단 추가해뒀습니당!
cofls6581
reviewed
Jan 29, 2023
| public DuDoongCodeException 티켓팅_시간지남 = EventTicketingTimeIsPassedException.EXCEPTION; | ||
|
|
||
| @ExplainError("티켓 아이템이 한 종류가 아닐 떄") | ||
| public DuDoongCodeException 아이템은_한종류여야함 = CartInvalidItemKindPolicyException.EXCEPTION; |
There was a problem hiding this comment.
지극히 개인적인 의견인데 CartInvalidItemKindPolicyException라는 워딩에서 티켓 아이템이 한 종류가 아닐 떄 발생하는 오류라는 직관적인 설명이 조오오금 덜 와닿는 것 같아요! NotOneItem~~이런식의 워딩도 좋은 것 같습니다.
There was a problem hiding this comment.
아 옛날에 만들어뒀던건데 수정할게유! 네네 그워딩이 좋아유
kim-wonjin
approved these changes
Jan 29, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
변경로직