Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 응원톡 생성 및 리스트 가져오기 API 작성 #199
feat: 응원톡 생성 및 리스트 가져오기 API 작성 #199
Changes from 7 commits
66d4bdb
de3f244
6aebf6f
e289f47
ff40394
13c1188
e4feb76
a806df6
8fb7c2f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DateFormat
....!!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그 궁금한게 있었는데 저렇게 jsonFormat으로 엮는거랑 정확한 차이가 궁금했습니당 @gengminy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4줄짜리 1줄로 줄여서 깔끔하게 만들어줘요 기능은 똑같애요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
티켓 예매관리나 관리자쪽에서는 ( 호스트에게 노출되는 환경 )
전화번호 까지 주는게 괜찮은것 같긴한데,
응원톡( 여러 사용자들에게 노출되는 환경에 )
전화번호 까지 주는건 무리가 있지않나 싶긴하네유..
따로 publicUserInfo 처럼 만들어야할듯 해요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
응원톡 리스트를 가져가는데 굳이 user의 모든 정보를 줘야할까? 고민해서 처음에는 userId만 넘기는 식으로 생각해봤었어요. 이런 방식으로 가면 좀 이상할까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그러게요 그냥 닉네임 정보받은거 내려주는게 맞지 않나 싶음
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
본인 글은 오른쪽에 떠야하는걸로 봐서 유저 정보는 내려주는게 맞지 않을까용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanbonai06
isMine 같은 dto 필드 만들어서 true false만 내려주심될듯요!