Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : 티켓상품 옵션 생성하기 #195

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Conversation

kim-wonjin
Copy link
Member

개요

작업사항

  • 이벤트에 속하는 티켓옵션을 생성하는 로직입니다.
  • request에서 바로 객체 생성하지 않고, mapper와 도메인 내부 메소드 사용하는 방식으로 변경했습니다
  • 이전 티켓상품 생성 로직도 추후 리펙토링 할 예정
  • 주관식 질문일 경우 선택지 answer에 빈문자열 넣었습니다.

변경로직

@kim-wonjin kim-wonjin added the Type: Feature [이슈 목적] 새로운 기능 추가 label Jan 24, 2023
@kim-wonjin kim-wonjin self-assigned this Jan 24, 2023
Copy link
Member

@sanbonai06 sanbonai06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 220 Code Smells

12.5% 12.5% Coverage
1.1% 1.1% Duplication

Copy link
Member

@ImNM ImNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뭐야 휴대폰으로 봐서그론가
깔끔하네유!!

Copy link
Member

@gengminy gengminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

Comment on lines +21 to +23
@NotNull
@Schema(nullable = false, example = "뒷풀이 참여 여부")
private String name;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"" 같은 빈 문자열도 검증하려면 @NotBlank 쓰는 방법도 좋을 거 같아요!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

동감합니당

Comment on lines +36 to +38
Host host = hostAdaptor.findById(event.getHostId());
// 권한 체크 ( 해당 이벤트의 호스트인지 )
host.hasHostUserId(user.getId());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 한 줄로 검증할 수 있게 HostService 에다가 한 번 만들어볼게요

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aop 로 만들수 있으면 좋을것 같긴합니다.
@gengminy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aop 로 만들수 있으면 좋을것 같긴합니다. @gengminy

만들어주시죠

@kim-wonjin kim-wonjin merged commit ebd923b into dev Jan 25, 2023
@kim-wonjin kim-wonjin deleted the feature/191-create-option branch January 25, 2023 07:58
@kim-wonjin kim-wonjin changed the title feat(ticketOption) : 티켓상품 옵션 생성하기 feat : 티켓상품 옵션 생성하기 Jan 30, 2023
@kim-wonjin kim-wonjin added the For: API [이슈 대상] 외부 API label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 [feature] 티켓상품 옵션 생성하기
4 participants