-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : 티켓상품 옵션 생성하기 #195
feat : 티켓상품 옵션 생성하기 #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⭐
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
뭐야 휴대폰으로 봐서그론가
깔끔하네유!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 👍
@NotNull | ||
@Schema(nullable = false, example = "뒷풀이 참여 여부") | ||
private String name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"" 같은 빈 문자열도 검증하려면 @NotBlank
쓰는 방법도 좋을 거 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
동감합니당
Host host = hostAdaptor.findById(event.getHostId()); | ||
// 권한 체크 ( 해당 이벤트의 호스트인지 ) | ||
host.hasHostUserId(user.getId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 한 줄로 검증할 수 있게 HostService 에다가 한 번 만들어볼게요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aop 로 만들수 있으면 좋을것 같긴합니다.
@gengminy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aop 로 만들수 있으면 좋을것 같긴합니다. @gengminy
만들어주시죠
개요
작업사항
변경로직