feat : 쿠폰 적용 가능한 주문 생성 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
cofls6581
reviewed
Jan 24, 2023
| private final IssuedCouponAdaptor issuedCouponAdaptor; | ||
|
|
||
| @Transactional | ||
| public Order WithOutCoupon(Long cartId, Long userId) { |
There was a problem hiding this comment.
통일성있게 함수명 소문자로 시작하면 좋을 것 같아요!
cofls6581
approved these changes
Jan 24, 2023
gengminy
approved these changes
Jan 25, 2023
| private final String name; | ||
| private String name; |
There was a problem hiding this comment.
그 요청받을때 final 되어있으면
못받더라고요.. 어느순간부터 그렇게 변경된것같음
기본생성자 없다고 요청 못받음!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
주문 생성 이벤트 소싱후
비동기가아닌 동기적 이벤트 수신으로 쿠폰 적용상태를 변경시킵니다.
before_commit role 이므로 실패한다면
주문 생성까지도 롤백됩니다.
또한 쿠폰 적용도 실패된다면 주문 생성 또한 롤백됩니다.
추후 채린이가 withdraworderevent 주문 철회 이벤트에 쿠폰 복구 작업예정입니다ㅏ
@cofls6581 혹시 지금 createOrderEvent 처럼 필요한 필드
가령 couponId , isUseCoupon 등 필드 필요하면 withdraworderevent에 추가하셔유!
변경로직