feat : 티켓 상품 생성 #164
Merged
feat : 티켓 상품 생성 #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofls6581
reviewed
Jan 20, 2023
| @Schema(nullable = false, example = "1") | ||
| private Long purchaseLimit; | ||
|
|
||
| public TicketItem toEntity(Event event) { |
There was a problem hiding this comment.
저도 처음에 request dto에 넣었었는데 mapper 만들어서 거기서 빌더쓰는 게 좀 더 깔끔해 보이는 것 같아요.
리팩토링하면 mapper로 옮기려구요.
ImNM
approved these changes
Jan 20, 2023
| @SecurityRequirement(name = "access-token") | ||
| @Tag(name = "티켓 상품 관련 컨트롤러") | ||
| @RestController | ||
| @RequestMapping("/v1/ticket_items") |
There was a problem hiding this comment.
ticketItems 로 해유!
저희 이렇게 컨벤션 자연스래? 맞춰진것같아요
ImNM
reviewed
Jan 20, 2023
Comment on lines
36
to
43
| hostService.hasHostUser(host, user.getId()); | ||
| // 호스트 제휴 여부에 따른 가격 체크 | ||
| if (!host.getPartner()) { | ||
| ticketItemService.checkTicketPrice(Money.wons(createTicketItemRequest.getPrice())); | ||
| } | ||
| TicketItem ticketItem = | ||
| ticketItemService.createTicketItem(createTicketItemRequest.toEntity(event)); | ||
| return CreateTicketItemResponse.from(ticketItem); |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
변경로직