-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : after order ticket create #162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImNM
changed the title
Feature/116 after order ticket create ( 민준이랑 이야기할예정 리뷰아직 x )
feat : after order ticket create ( 리뷰아직 x )
Jan 20, 2023
sanbonai06
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했슴다! 수고하셨어용 머지하면 받아서 작업 하겠습니당
ImNM
changed the title
feat : after order ticket create ( 리뷰아직 x )
feat : after order ticket create
Jan 20, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
cofls6581
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
@Async
빠졌다는 소리입니다!transaction phase before commit으로 놓아서
해당 이벤트 핸들러 메소드 들이 트랜잭션이 커밋 되기 이전에 수행됩니다.
따라서 티켓 발급 수행시에 추후에 들어갈 재고 감소 로직이나,
티켓 발급시 에러 발생하면
주문 쪽 까지 롤백 됩니다.
또한 주문 rollback 과정속에서 토스 쪽 결제가 이미 승인된 상태면
결제 취소를 다시해줘야하는데 그부분은
transaction phase after rollback 옵션으로
해결했습니다.
토스쪽은 멱등성 보장되므로 여러번 요청보내도 상관없슴다!
변경로직