Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : 에러코드 도메인 별로 분할 (#117) #129

Merged
merged 4 commits into from
Jan 15, 2023
Merged

refactor : 에러코드 도메인 별로 분할 (#117) #129

merged 4 commits into from
Jan 15, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Jan 15, 2023

개요

작업사항

  • 에러코드를 도메인별루 분할시켰습니다.
  • 컨플릭트 날 위험이 줄었습니다.
  • 앞으로 작업하실때 도메인 내부에 에러코드 위치시켜주세요
  • 글로벌 성격띄는건 글로벌에 놔주시고!!

변경로직

  • 민준이 에러코드에서 403 반환하는건 400으로 변환했습니다!
  • 왜냐면 클라쪽에 403잡으면 바로 로그아웃 시키는 로직으로 하기로해서
  • 401, 403 상태코드는 왠만하면 안쓰시면 되겠습니다!!
  • 400, 404 위주로 활용해주세염

@ImNM ImNM added For: Utils [이슈 대상] API, 모델, 뷰를 제외한 백엔드 로직 Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 labels Jan 15, 2023
@ImNM ImNM self-assigned this Jan 15, 2023
cofls6581
cofls6581 approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@cofls6581 cofls6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 쿠폰쪽도 새 이셉션처리 방식대로 수정 완!

sanbonai06
sanbonai06 approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@sanbonai06 sanbonai06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에러코드 분할 및 403 안쓰는거 확인했습니다!
LGTM ⭐

@ImNM ImNM merged commit 69b037c into dev Jan 15, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 169 Code Smells

6.2% 6.2% Coverage
1.2% 1.2% Duplication

@ImNM ImNM deleted the refactor/117-errorcode-to-domain branch January 15, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofls6581 cofls6581 cofls6581 approved these changes

@sanbonai06 sanbonai06 sanbonai06 approved these changes

@gengminy gengminy Awaiting requested review from gengminy gengminy is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@ImNM ImNM

Labels
For: Utils [이슈 대상] API, 모델, 뷰를 제외한 백엔드 로직 Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔨[refactor] 에러코드 도메인 별로 분할
3 participants
@ImNM @sanbonai06 @cofls6581