refactor(api) : 발급 티켓 API 관련 리팩토링 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImNM
approved these changes
Jan 13, 2023
Comment on lines
158
to
167
| return IssuedTicketInfoVo.builder() | ||
| .issuedTicketId(issuedTicket.getId()) | ||
| .issuedTicketNo(issuedTicket.getIssuedTicketNo()) | ||
| .uuid(issuedTicket.getUuid()) | ||
| .ticketName(issuedTicket.getTicketItem().getName()) | ||
| .ticketPrice(issuedTicket.getPrice()) | ||
| .createdAt(issuedTicket.getCreatedAt()) | ||
| .issuedTicketStatus(issuedTicket.getIssuedTicketStatus()) | ||
| .optionPrice(issuedTicket.sumOptionPrice()) | ||
| .build(); |
There was a problem hiding this comment.
IssuedTicketInfoVo 안에 from 정적 스테직 메서드 만들어서
집어넣으면 더깔금해질것같아유!
Comment on lines
+169
to
+172
|
|
||
| public static CreateIssuedTicketResponse orderLineItemToIssuedTickets( | ||
| CreateIssuedTicketDTO dto) { | ||
| long quantity = dto.getOrderLineItem().getQuantity(); |
There was a problem hiding this comment.
IssuedTicket 도메인에 뷰를 위한 응답값을 의존하는게 쬐금 맘에 걸리긴하네유
| @@ -72,4 +73,14 @@ public void login() { | |||
| throw ForbiddenUserException.EXCEPTION; | |||
| } | |||
| } | |||
|
|
|||
| public UserInfoVo toUserInfoVo(User user) { | |||
| return UserInfoVo.builder() | |||
There was a problem hiding this comment.
UserInfoVo
안에
publice static UserInfoVo from(User user){
return 빌더넣기
}
요래 바꿀수 있을듯!
|
|
||
| private final Order order; | ||
|
|
||
| private final OrderLineItem orderLineItem; |
There was a problem hiding this comment.
약간 그림이 주문 도메인 하나만받아서
제가 카드 -> 주문 변환하는것처럼
그런걸생각했긴 했어유!
지금방식도 좋습다!
gengminy
approved these changes
Jan 13, 2023
| .createdAt(issuedTicket.getCreatedAt()) | ||
| .issuedTicketStatus(issuedTicket.getIssuedTicketStatus()) | ||
| .optionPrice(issuedTicket.sumOptionPrice()) | ||
| .build(); |
There was a problem hiding this comment.
저같은 경우에도 찬진님처럼 매개변수로 도메인 객체 받는
static 메서드 of 구현해서 생성하는 방식을 선호하는데
한번 고려해 보세용
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
변경로직