Handle iPhone 4s and possibly iPad2/3 without checking hardware strings #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hone resolution Previously bar code recognition did not work on iPhone 4s as code checked only for iPhone 4. Reimplemented this code to be iPhone hardware agnostic, only checks if device is iPhone or iPad and if has retina display or not. iPad constants probably need to be modified as I don't have an iPad to test with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks to handle device type (ipad vs iphone via UIUserInterfaceIdiom) and whether screen is retina or not, and then use these facts to scale picFrame.