GooseFX is now compatible with the Solana Mobile Wallet Adapter protocol #536
Conversation
src/utils/wallets.ts
Outdated
| new SolanaMobileWalletAdapter({ | ||
| appIdentity: { name: 'Goosefx App' }, | ||
| authorizationResultCache: createDefaultAuthorizationResultCache(), | ||
| addressSelector: createDefaultAddressSelector(), | ||
| cluster: network, | ||
| onWalletNotFound: createDefaultWalletNotFoundHandler() | ||
| }), |
There was a problem hiding this comment.
I moved this to the top of the list because it gets filtered out:
- on desktop
- when on a non-supported mobile device (eg. iOS)
You can see this in the desktop test plan video.
|
Hi @steveluscher - I believe these changes have already been pulled into a working branch via PR 532? There are some changes I need to make regarding custom connection logic we have on our wallets. That is why I currently have those changes in a working branch, not in dev at moment. If I need to disregard that PR and merge this, let me know. I will need to change the base branch to make those changes. |
Not quite! These are Mobile Wallet Adapter specific fixes that follow from that PR. |
|
Since your changes are based on a branch that do not reflect Jordan's implementations, it is hard to decipher what changes are needed to promote. Specifically regarding the dependencies. Jordan has changed react/types versions, solana package versions, and "@solana/wallet-adapter-base", "@solana/wallet-adapter-react", and "@solana/wallet-adapter-wallets" have more up to date versions. Can you take a look at the package.json file with his branch being the base to sort out the dependencies/versions? |
|
Sure thing! I just mashed ‘fork’ presuming that Jordan’s changes were already merged. I’ll rebase a bit later! |
|
Done, @lukewalt! I updated this PR, with |
|
Thanks @steveluscher - I will keep an eye on the status of this PR and will merge when ready! |
|
Alright! I retested this and believe it's good to go. Review welcome! |
Description
In this PR we filter out MWA if it's determined not to be supported, and make it so that, when the MWA is selected, clicking the connect button starts a connection instead of popping open the dialog.
Test plan
Mobile, with mobile wallet
480.mov
Desktop
Screen.Recording.2022-10-27.at.2.01.36.PM.mov