Blocks: Fix hidden lightbox interfering with rest of the page #13589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.web-stories-list__lightbox` and `.web-stories-singleton__lightbox`
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Plugin builds for 5649bb5 are ready 🛎️!
|
|
Size Change: +11 B (0%) Total Size: 2.76 MB ℹ️ View Unchanged
|
swissspidy
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the conflict between the Web Stories blocks and theme hamburger menu on mobile devices.
Summary
To fix the issue,
z-index: -999999999;is added to.web-stories-list__lightboxand.web-stories-singleton__lightboxclasses.User-facing changes.
Before:
RPReplay_Final1707376252.mov
After:
RPReplay_Final1707376357.MP4
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No.
Does this PR change what data or activity we track or use?
No.
Does this PR have a legal-related impact?
No.
Checklist
Type: XYZlabel to the PRFixes #13587