Fix TinyMCE classic editor integration #12268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 33e916f are ready 🛎️!
|
|
Size Change: -15 B (0%) Total Size: 2.68 MB
ℹ️ View Unchanged
|
timarney
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
While looking into e2e tests I noticed an issue with the TinyMCE button integration in the classic editor, which was causing tons of JavaScript errors.
Summary
Fixes console errors to ensure the TinyMCE button works again as expected.
Relevant Technical Choices
Updated
@wordpress/datausage according to best practices. Uses functions that are available since WordPress 5.7, so compatibility is given.Also simplified the code a little bit to make it easier to maintain.
To-do
User-facing changes
TinyMCE integration should be
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #