Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale back the code. #12264

Closed

Conversation

spacedmonkey
Copy link
Contributor

Context

While reviewing #12197, I discovery that that data needed for this functionality is already in the REST API. As it is hard to point developers in the right direction, here is an example of how this functionality could work.

Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #

@spacedmonkey spacedmonkey self-assigned this Sep 8, 2022
@spacedmonkey spacedmonkey mentioned this pull request Sep 8, 2022
8 tasks
@timarney
Copy link
Contributor

timarney commented Sep 8, 2022

Commits cherry picked into #12197 (comment)

@swissspidy swissspidy deleted the fix/85-link-to-revisions-2 branch September 9, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants